Merge pull request #607 from crazy-max/allow-comments

preserve comments in list input values with commentNoInfix
chore: update generated content
2026-03-06 08:13:07 +08:00 · 2026-03-05 08:21:07 -08:00 · 2026-03-05 17:02:53 +01:00 · 2026-03-05 17:02:53 +01:00
4 changed files with 68 additions and 7 deletions
--- a/tests/context.test.ts
+++ b/tests/context.test.ts
@ -79,6 +79,67 @@ describe('getInputs', () => {
        tags: [],
      }
    ],
+    [
+      3,
+      new Map<string, string>([
+        ['labels', 'mylabel=foo#bar\n#comment\nanother=bar'],
+      ]),
+      {
+        context: context.ContextSource.workflow,
+        bakeTarget: 'docker-metadata-action',
+        flavor: [],
+        githubToken: '',
+        images: [],
+        labels: ['mylabel=foo#bar', 'another=bar'],
+        annotations: [],
+        sepLabels: '\n',
+        sepTags: '\n',
+        sepAnnotations: '\n',
+        tags: [],
+      }
+    ],
+    [
+      4,
+      new Map<string, string>([
+        ['annotations', 'org.opencontainers.image.url=https://example.com/path#readme\n#comment\norg.opencontainers.image.source=https://github.com/docker/metadata-action'],
+      ]),
+      {
+        context: context.ContextSource.workflow,
+        bakeTarget: 'docker-metadata-action',
+        flavor: [],
+        githubToken: '',
+        images: [],
+        labels: [],
+        annotations: [
+          'org.opencontainers.image.url=https://example.com/path#readme',
+          'org.opencontainers.image.source=https://github.com/docker/metadata-action'
+        ],
+        sepLabels: '\n',
+        sepTags: '\n',
+        sepAnnotations: '\n',
+        tags: [],
+      }
+    ],
+    [
+      5,
+      new Map<string, string>([
+        ['tags', 'type=raw,value=foo#bar\n#comment'],
+        ['flavor', 'prefix=v#1\n#comment'],
+      ]),
+      {
+        context: context.ContextSource.workflow,
+        bakeTarget: 'docker-metadata-action',
+        flavor: ['prefix=v#1'],
+        githubToken: '',
+        images: [],
+        labels: [],
+        annotations: [],
+        sepLabels: '\n',
+        sepTags: '\n',
+        sepAnnotations: '\n',
+        tags: ['type=raw,value=foo#bar'],
+      }
+    ],
  ];
  test.each(cases)('[%d] given %o as inputs, returns %o', async (num: number, inputs: Map<string, string>, expected: context.Inputs) => {
    inputs.forEach((value: string, name: string) => {
--- a/dist/index.js
+++ b/dist/index.js
--- a/dist/index.js.map
+++ b/dist/index.js.map
--- a/src/context.ts
+++ b/src/context.ts
@ -28,11 +28,11 @@ export interface Inputs {
 export function getInputs(): Inputs {
  return {
    context: (core.getInput('context') || ContextSource.workflow) as ContextSource,
-    images: Util.getInputList('images', {ignoreComma: true, comment: '#'}),
-    tags: Util.getInputList('tags', {ignoreComma: true, comment: '#'}),
-    flavor: Util.getInputList('flavor', {ignoreComma: true, comment: '#'}),
-    labels: Util.getInputList('labels', {ignoreComma: true, comment: '#'}),
-    annotations: Util.getInputList('annotations', {ignoreComma: true, comment: '#'}),
+    images: Util.getInputList('images', {ignoreComma: true, comment: '#', commentNoInfix: true}),
+    tags: Util.getInputList('tags', {ignoreComma: true, comment: '#', commentNoInfix: true}),
+    flavor: Util.getInputList('flavor', {ignoreComma: true, comment: '#', commentNoInfix: true}),
+    labels: Util.getInputList('labels', {ignoreComma: true, comment: '#', commentNoInfix: true}),
+    annotations: Util.getInputList('annotations', {ignoreComma: true, comment: '#', commentNoInfix: true}),
    sepTags: core.getInput('sep-tags', {trimWhitespace: false}) || `\n`,
    sepLabels: core.getInput('sep-labels', {trimWhitespace: false}) || `\n`,
    sepAnnotations: core.getInput('sep-annotations', {trimWhitespace: false}) || `\n`,
Author	SHA1	Message	Date
Tõnis Tiigi	030e881283	Merge pull request #607 from crazy-max/allow-comments Some checks are pending ci / tag-schedule () (push) Waiting to run Details ci / tag-schedule (cron-{{date 'YYYYMMDD'}}) (push) Waiting to run Details ci / tag-schedule (schedule) (push) Waiting to run Details ci / tag-schedule ({{date 'YYYYMMDD-HHmmss'}}) (push) Waiting to run Details ci / tag-match (\d.\d, 0) (push) Waiting to run Details ci / tag-match (\d.\d.\d, 0) (push) Waiting to run Details ci / tag-match (v(.*), 1) (push) Waiting to run Details ci / tag-semver (auto) (push) Waiting to run Details ci / tag-semver (false) (push) Waiting to run Details ci / tag-semver (true) (push) Waiting to run Details ci / flavor (push) Waiting to run Details ci / images (push) Waiting to run Details ci / custom-labels-annotations (push) Waiting to run Details ci / global-exps (push) Waiting to run Details ci / json (push) Waiting to run Details ci / docker-push (push) Waiting to run Details ci / bake (push) Waiting to run Details ci / sep-tags ( ) (push) Waiting to run Details ci / sep-tags (,) (push) Waiting to run Details ci / output-env (push) Waiting to run Details ci / no-output-env (push) Waiting to run Details ci / bake-annotations (push) Waiting to run Details ci / no-images (push) Waiting to run Details ci / bake-path-context (push) Waiting to run Details ci / sha-short () (push) Waiting to run Details ci / sha-short (16) (push) Waiting to run Details ci / dump (push) Waiting to run Details test / test (push) Waiting to run Details validate / prepare (push) Waiting to run Details validate / validate (push) Blocked by required conditions Details preserve comments in list input values with commentNoInfix	2026-03-05 08:21:07 -08:00
CrazyMax	4b529ac4e5	chore: update generated content Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>	2026-03-05 17:02:53 +01:00
CrazyMax	b0082b33bc	preserve comments in list input values with commentNoInfix Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>	2026-03-05 17:02:53 +01:00