From bd3d352542de947a9ee044d9c8059f60dd5c0ce6 Mon Sep 17 00:00:00 2001 From: Emilien Escalle Date: Thu, 6 Aug 2026 08:38:59 +0000 Subject: [PATCH] chore: misc DevX improvments Signed-off-by: Emilien Escalle --- .devcontainer/devcontainer.json | 2 +- .github/workflows/__shared-ci.yml | 9 --------- .github/workflows/greetings.yml | 2 +- .github/workflows/semantic-pull-request.yml | 2 +- Makefile | 15 +++++++++------ package.json | 2 +- 6 files changed, 13 insertions(+), 19 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 16c75f0..2d22806 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,6 +1,6 @@ { "name": "Debian", - "image": "mcr.microsoft.com/devcontainers/base:bullseye", + "image": "mcr.microsoft.com/devcontainers/base:debian", "features": { "ghcr.io/devcontainers/features/common-utils:2": { "configureZshAsDefaultShell": true diff --git a/.github/workflows/__shared-ci.yml b/.github/workflows/__shared-ci.yml index 6e92eb0..d691e65 100644 --- a/.github/workflows/__shared-ci.yml +++ b/.github/workflows/__shared-ci.yml @@ -16,15 +16,6 @@ jobs: pull-requests: write security-events: write statuses: write - with: - linter-env: | - FILTER_REGEX_EXCLUDE=dist/**/*|.github/social-preview.svg|.github/logo.svg - VALIDATE_JSCPD=false - VALIDATE_TYPESCRIPT_STANDARD=false - VALIDATE_TYPESCRIPT_ES=false - VALIDATE_TYPESCRIPT_PRETTIER=false - VALIDATE_JAVASCRIPT_ES=false - VALIDATE_JAVASCRIPT_STANDARD=false check-nodejs: name: Test nodejs diff --git a/.github/workflows/greetings.yml b/.github/workflows/greetings.yml index 3c62a12..6c9366d 100644 --- a/.github/workflows/greetings.yml +++ b/.github/workflows/greetings.yml @@ -3,7 +3,7 @@ name: Greetings on: issues: types: [opened] - pull_request_target: # zizmor: ignore[dangerous-triggers] metadata-only reusable workflow with explicit write permissions and no checkout + pull_request: branches: [main] permissions: {} diff --git a/.github/workflows/semantic-pull-request.yml b/.github/workflows/semantic-pull-request.yml index 02c2454..71820a4 100644 --- a/.github/workflows/semantic-pull-request.yml +++ b/.github/workflows/semantic-pull-request.yml @@ -1,7 +1,7 @@ name: "Pull Request - Semantic Lint" on: - pull_request_target: # zizmor: ignore[dangerous-triggers] validates PR metadata only through a pinned reusable workflow without checkout + pull_request: types: - opened - edited diff --git a/Makefile b/Makefile index 41b06f4..0cd1c28 100644 --- a/Makefile +++ b/Makefile @@ -3,6 +3,9 @@ help: ## Display help @grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}' +setup: ## Install dependencies + @npm install + lint: ## Execute linting $(call run_linter,) @@ -17,7 +20,7 @@ lint-fix: ## Execute linting and fix ) ci: ## Execute all formats and checks - @npm install + $(MAKE) setup @npm audit fix || true @npm run all $(MAKE) lint-fix @@ -26,14 +29,14 @@ define run_linter DEFAULT_WORKSPACE="$(CURDIR)"; \ LINTER_IMAGE="linter:latest"; \ VOLUME="$$DEFAULT_WORKSPACE:$$DEFAULT_WORKSPACE"; \ - docker build --build-arg UID=$(shell id -u) --build-arg GID=$(shell id -g) --tag $$LINTER_IMAGE .; \ + docker build --platform=linux/amd64 --build-arg UID=$(shell id -u) --build-arg GID=$(shell id -g) --tag $$LINTER_IMAGE .; \ docker run \ - -e DEFAULT_WORKSPACE="$$DEFAULT_WORKSPACE" \ - -e FILTER_REGEX_EXCLUDE="dist/**/*|.github/social-preview.svg|.github/logo.svg" \ - -e FILTER_REGEX_INCLUDE="$(filter-out $@,$(MAKECMDGOALS))" \ - $(1) \ + --platform=linux/amd64 \ -v $$VOLUME \ --rm \ + -e DEFAULT_WORKSPACE="$$DEFAULT_WORKSPACE" \ + -e FILTER_REGEX_INCLUDE="$(filter-out $@,$(MAKECMDGOALS))" \ + $(1) \ $$LINTER_IMAGE endef diff --git a/package.json b/package.json index b0ed981..06cae42 100644 --- a/package.json +++ b/package.json @@ -61,6 +61,6 @@ "version": "20260604100000-migrate-to-vitest" }, "allowScripts": { - "esbuild@0.27.7": true + "esbuild@0.28.1": true } }